Move off deprecated log events #90

xrmx · 2025-08-25T15:37:35Z

What does this pull request do?

This PR moves to OpenTelemetry 1.35.0 as baseline to move off deprecated log events and use log records directly. The telemetry output does not change.

Related issues

Closes #85

xrmx · 2025-08-27T13:28:21Z

@anuraaga Could you please take a look? Should I just remove the beta chat completions instrumentation?

fr4nc1sc0-r4m0n

LGTM --> The CI changes

anuraaga · 2025-08-28T03:19:57Z

@xrmx Personally I would remove the beta chat instrumentation indeed since I think it's superceded by the responses API

instrumentation/elastic-opentelemetry-instrumentation-openai/pyproject.toml

anuraaga · 2025-09-04T06:54:50Z

@xrmx Personally I would remove the beta chat instrumentation indeed since I think it's superceded by the responses API

But the current version ceiling looks fine too

anuraaga · 2025-09-04T07:45:39Z

@xrmx Sorry I realized I needed to refresh my venv when testing. Actually I still had an issue when trying it out

  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py", line 113, in export
    return self._export(batch)
           ~~~~~~~~~~~~^^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/exporter.py", line 316, in _export
    request=self._translate_data(data),
            ~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py", line 110, in _translate_data
    return encode_logs(data)
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py", line 37, in encode_logs
    return ExportLogsServiceRequest(resource_logs=_encode_resource_logs(batch))
                                                  ~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py", line 74, in _encode_resource_logs
    sdk_resource = sdk_log.log_record.resource
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'LogRecord' object has no attribute 'resource'

AFAICT, this is because of open-telemetry/opentelemetry-python#4319

I came up with a workaround to force use the SDK LogRecord - it's a bit too hairy for me to commit directly to this PR so I sent a PR for this PR.

#91

I also had to work around severity_number crash which is probably an easier to fix bug in the logs exporter

  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py", line 113, in export
    return self._export(batch)
           ~~~~~~~~~~~~^^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/exporter.py", line 316, in _export
    request=self._translate_data(data),
            ~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py", line 110, in _translate_data
    return encode_logs(data)
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py", line 37, in encode_logs
    return ExportLogsServiceRequest(resource_logs=_encode_resource_logs(batch))
                                                  ~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py", line 76, in _encode_resource_logs
    pb2_log = _encode_log(sdk_log)
  File "/Users/anuraag/git/observability-examples/genai-function-calling/openai-agents/.venv/lib/python3.13/site-packages/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py", line 64, in _encode_log
    severity_number=log_data.log_record.severity_number.value,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'value'

Given the logs SDK doesn't seem to be working well currently, should we hold off on this PR? I recommend splitting off the beta fix, either as the version ceiling or removing the instrumentation, to a separate PR to get it released ASAP to support newer openai versions.

xrmx · 2025-09-09T12:48:08Z

@anuraaga I think the ceiling fix is required just for CI and wrapt would just ignore silently stuff that was not able to wrap.

xrmx · 2025-09-19T12:57:37Z

@anuraaga rebased and bumped baseline after fixing Logger.emit for API Logrecord upstream.

...tic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py

codefromthecrypt · 2025-09-30T08:21:27Z

any chance we can land this before elasticon NYC? (like in a week)? there's some significant tech debt until this is merged and released.

xrmx · 2025-10-01T10:13:06Z

any chance we can land this before elasticon NYC? (like in a week)? there's some significant tech debt until this is merged and released.

Yeah, we should be able do that

xrmx force-pushed the use-logger branch 2 times, most recently from 2d2d8d8 to 1974277 Compare August 27, 2025 13:25

xrmx marked this pull request as ready for review August 27, 2025 13:27

xrmx requested review from a team as code owners August 27, 2025 13:27

fr4nc1sc0-r4m0n approved these changes Aug 27, 2025

View reviewed changes

basepi approved these changes Aug 29, 2025

View reviewed changes

anuraaga reviewed Sep 4, 2025

View reviewed changes

instrumentation/elastic-opentelemetry-instrumentation-openai/pyproject.toml Outdated Show resolved Hide resolved

anuraaga mentioned this pull request Sep 4, 2025

Workaround broken logs SDK #91

Closed

xrmx force-pushed the use-logger branch from 64162c3 to d594762 Compare September 19, 2025 12:55

xrmx added 8 commits September 19, 2025 14:56

Move off deprecated log events

4f02d9c

Keep an old httpx version for baseline testing

0eb7054

Drop backports-asyncio-runner for newer pythons

5bf0676

Keep compat with attributes sent by Event

ce5064a

Stop running CI on Python 3.8

2d0285f

Bump baseline to py3.9

81e0a8a

beta chat completions are gone in recent openai versions

3d77728

Bump baseline to 1.37.0

9341bbb

xrmx force-pushed the use-logger branch from d594762 to 9341bbb Compare September 19, 2025 12:56

xrmx requested a review from anuraaga September 19, 2025 12:59

xrmx closed this Sep 19, 2025

xrmx reopened this Sep 19, 2025

anuraaga reviewed Sep 20, 2025

View reviewed changes

...tic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py Show resolved Hide resolved

...tic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py Show resolved Hide resolved

xrmx requested a review from anuraaga October 1, 2025 10:19

anuraaga approved these changes Oct 1, 2025

View reviewed changes

xrmx merged commit 70d798a into main Oct 1, 2025
40 checks passed

xrmx mentioned this pull request Oct 2, 2025

Silence LogRecord SDK deprecation warnings #94

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move off deprecated log events #90

Move off deprecated log events #90

Uh oh!

xrmx commented Aug 25, 2025 •

edited

Loading

Uh oh!

xrmx commented Aug 27, 2025 •

edited

Loading

Uh oh!

fr4nc1sc0-r4m0n left a comment •

edited

Loading

Uh oh!

anuraaga commented Aug 28, 2025

Uh oh!

Uh oh!

anuraaga commented Sep 4, 2025

Uh oh!

anuraaga commented Sep 4, 2025

Uh oh!

xrmx commented Sep 9, 2025

Uh oh!

xrmx commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

codefromthecrypt commented Sep 30, 2025

Uh oh!

xrmx commented Oct 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Move off deprecated log events #90

Move off deprecated log events #90

Uh oh!

Conversation

xrmx commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this pull request do?

Related issues

Uh oh!

xrmx commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fr4nc1sc0-r4m0n left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anuraaga commented Aug 28, 2025

Uh oh!

Uh oh!

anuraaga commented Sep 4, 2025

Uh oh!

anuraaga commented Sep 4, 2025

Uh oh!

xrmx commented Sep 9, 2025

Uh oh!

xrmx commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

codefromthecrypt commented Sep 30, 2025

Uh oh!

xrmx commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrmx commented Aug 25, 2025 •

edited

Loading

xrmx commented Aug 27, 2025 •

edited

Loading

fr4nc1sc0-r4m0n left a comment •

edited

Loading

xrmx commented Oct 1, 2025 •

edited

Loading